Add hasfield to check for field existence #27582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
previously approved these changes
Jun 14, 2018
ararslan
added
needs tests
|
The doctest is not enough? |
|
No, doctests are nice to have but pretty much everything should have a unit test. Weird that |
|
I think this is fine for now. For future reference, I notice that both this and some existing functions like fieldoffset and fieldname should be expanded to handle more types using the technique that |
|
Could you add an entry for this in NEWS.md as well? |
ararslan
approved these changes
Jun 15, 2018
|
Closing in favour of #30496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted this in another package but I figure it's general and useful enough for Base.